Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TryStreamExt::try_buffered #2245

Merged
merged 3 commits into from
Nov 2, 2020
Merged

Add TryStreamExt::try_buffered #2245

merged 3 commits into from
Nov 2, 2020

Conversation

khuey
Copy link
Contributor

@khuey khuey commented Oct 31, 2020

A copy of TryBufferUnordered, with the underlying FuturesUnordered swapped out for a FuturesOrdered.

taiki-e
taiki-e requested changes Oct 31, 2020
View reviewed changes
Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Please add doc examples or tests.

@khuey
Copy link
Contributor Author

khuey commented Nov 2, 2020

Alright, how about that?

taiki-e
taiki-e approved these changes Nov 2, 2020
View reviewed changes
Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@taiki-e taiki-e merged commit 90b4a8e into rust-lang:master Nov 2, 2020
@taiki-e taiki-e mentioned this pull request Nov 4, 2020
Merged
@taiki-e taiki-e added A-stream Area: futures::stream and removed C-feature-request labels Jan 6, 2021
@dependabot dependabot bot mentioned this pull request Mar 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e approved these changes

Assignees
No one assigned
Labels
A-stream Area: futures::stream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khuey @taiki-e